Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: snapshot release workflow #8884

Merged
merged 1 commit into from
Oct 21, 2023
Merged

fix: snapshot release workflow #8884

merged 1 commit into from
Oct 21, 2023

Conversation

alexanderniebuhr
Copy link
Member

@alexanderniebuhr alexanderniebuhr commented Oct 21, 2023 •
edited
Loading

Changes

  • fixes snapshot release expression matching

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2023

⚠️ No Changeset found

Latest commit: 3b77363

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alexanderniebuhr
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions github-actions bot added the 🚨 action Modifies GitHub Actions label Oct 21, 2023
natemoo-re
natemoo-re approved these changes Oct 21, 2023
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Sorry about that. Copied the contains(fromJSON('["value"'])) example from the GitHub docs, but I guess I was too optimistic 😢

@natemoo-re natemoo-re merged commit d5dc5ce into main Oct 21, 2023
@natemoo-re natemoo-re deleted the nbhr/fix_snapshot_release_workflow branch October 21, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemoo-re natemoo-re natemoo-re approved these changes

Assignees
No one assigned
Labels
🚨 action Modifies GitHub Actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexanderniebuhr @natemoo-re